fix: change big_face default to false in vnf_validate (#1563)#1969
Open
junhinhow wants to merge 1 commit intoBelfrySCAD:masterfrom
Open
fix: change big_face default to false in vnf_validate (#1563)#1969junhinhow wants to merge 1 commit intoBelfrySCAD:masterfrom
junhinhow wants to merge 1 commit intoBelfrySCAD:masterfrom
Conversation
The BIG_FACE check (faces with more than 3 vertices) generated warnings for valid geometry that intentionally uses quads or larger polygons. Changes: - Set big_face=false by default in vnf_validate() module - Function form already defaulted to false, now module matches - Fix typo "big_false" -> "big_face" in documentation - Update description to clarify the parameter's purpose
junhinhow
force-pushed
the
fix/vnf-validate-1563
branch
from
404650c to
53d3d90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code