Fix XP increase when restoring advancements on world switch

[Copilot]

Some Minecraft advancements reward XP when their criteria are awarded. When setAdvancements() restored a player's advancements on world entry, those XP rewards fired, increasing the player's experience beyond the stored value on every teleport.

Changes

• Store.setAdvancements(): Save the player's current XP before calling awardCriteria() on any advancement, then restore it afterward. Returns early if there are no stored advancements to avoid unnecessary XP calls.

// Save current experience before granting advancements, because some advancements
// reward XP when their criteria are awarded, which would incorrectly increase the
// player's experience points.
int savedExp = getTotalExperience(player);
advancements.forEach((k, v) -> { ... });
// Restore experience to prevent advancement rewards from modifying it
setTotalExperience(player, savedExp);

• StoreTest: Add testGetInventoryAdvancementsPreservesExperience — stores a player with a completed advancement, then calls getInventory and asserts setTotalExperience is called the expected number of times (including the restoration call inside setAdvancements).

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud