Support LFortran and simplify assertions#61
Merged
rouson merged 14 commits intoBerkeleyLab:mainfrom Jul 17, 2025
Merged
Conversation
bonachea
requested changes
Jul 4, 2025
Member
bonachea
left a comment
bonachea
left a comment
There was a problem hiding this comment.
In today's meeting we decided to keep the scope of this PR unchanged (including both the removal of diagnostic_data and the port to LFortran). Please resist appending any additional unrelated features.
I've migrated unresolved comments from PR #56.
This commit 1. Removes the diagnostic_data argument from the assert subroutine 2. Removes the types that existed solely to support that argument: a. characterizable_t b. intrinsic_array_t 3. Edits or deletes examples that referenced the removed entities 4. Edits or deletes documentation that referenced removed entities
Also manually inline string function.
bonachea
force-pushed
the
lfortran-and-simpler-assert
branch
from
3f9a433 to
c736489
Compare
* Fix defects introduced while adding LFortran support that broke several other configurations. * Disentangle file-passing of exit status from multi-image, so that it's properly compiler-specific * Use co_max in place of co_reduce for multi-image (cherry picked from commit f1d96ff)
bonachea
approved these changes
Jul 17, 2025
Member
bonachea
left a comment
bonachea
left a comment
There was a problem hiding this comment.
LGTM with the commits I've added
rouson
commented
Jul 17, 2025
rm fpm profile with nagfor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
diagnostic_dataargument in assertions, which breaks backwards compatibility.