Skip to content

Conversation

@jason-raitz
Copy link
Contributor

…istory and instructions.

Copy link
Member

@anarchivist anarchivist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting work - i'm excited to see this proceeding.

@jason-raitz jason-raitz force-pushed the AP-532_cohere_structured_query branch from 9cce4d4 to e999fa8 Compare December 19, 2025 16:28
@jason-raitz jason-raitz force-pushed the AP-532_cohere_structured_query branch from 326d731 to ea41942 Compare January 2, 2026 16:40
 - this gets cohere specific response field that includes citations for the response text
 - temporarily add raw citations to response.
@jason-raitz jason-raitz force-pushed the AP-532_cohere_structured_query branch from ea41942 to 595169c Compare January 5, 2026 20:19
Copy link
Member

@awilfox awilfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good and I'm glad to see this. It feels like the beginning of cleaning up Graph Manager to be more coherent (no pun intended) and easier to follow.

A few nits, and a single question. After those are handled, r+ from me.

Copy link
Member

@anarchivist anarchivist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of questions around error handling and typing, but largely looks good.

@jason-raitz jason-raitz marked this pull request as ready for review January 7, 2026 15:40
Copilot AI review requested due to automatic review settings January 7, 2026 15:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the chatbot's graph workflow to separate document retrieval from message preparation, introducing a clearer separation of concerns between context retrieval and response generation.

Key Changes:

  • Introduced a new workflow node prepare_for_generation to separate message preparation from response generation
  • Replaced the docs_context string-based approach with structured documents list containing metadata
  • Modified the prompt system to no longer inject context directly into the system message, instead passing documents via additional_model_request_fields

refactor and addressing some @awilfox and copilot suggestions
Copy link
Member

@awilfox awilfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested locally yet, but looks good to me. Thank you for splitting it off the other changes and tidying it up! :shipit:

Copy link
Member

@anarchivist anarchivist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming that i have tested this locally and it's ready to go 🚀

@jason-raitz jason-raitz merged commit 791a2e1 into main Jan 8, 2026
9 checks passed
@jason-raitz jason-raitz deleted the AP-532_cohere_structured_query branch January 8, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants