Skip to content

Fix BIOCONDUCTOR_NAME reflecting devel on all release images#141

Open
Copilot wants to merge 1 commit into
develfrom
copilot/debug-biocondutor-name-variable
Open

Fix BIOCONDUCTOR_NAME reflecting devel on all release images#141
Copilot wants to merge 1 commit into
develfrom
copilot/debug-biocondutor-name-variable

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026

BIOCONDUCTOR_NAME was hardcoded to bioconductor_docker_devel-<arch> in the Dockerfile, so every image — including release tags like RELEASE_3_23 — reported the wrong name at runtime.

Change

Replace the hardcoded devel string with the BIOCONDUCTOR_VERSION ARG (already declared in the same final stage):

# Before
ENV BIOCONDUCTOR_NAME="bioconductor_docker_devel-$TARGETARCH"

# After
ENV BIOCONDUCTOR_NAME="bioconductor_docker_${BIOCONDUCTOR_VERSION}-${TARGETARCH}"

This produces the correct value for every branch at build time without any workflow changes:

Branch BIOCONDUCTOR_NAME
devel bioconductor_docker_3.24-amd64
RELEASE_3_23 bioconductor_docker_3.23-amd64

@LiNk-NY LiNk-NY requested a review from almahmoud May 13, 2026 22:47
@LiNk-NY LiNk-NY marked this pull request as ready for review May 13, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants