Skip to content

fix: add back in verifyTransaction #8907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidkaplanbitgo merged 1 commit into from
Jun 1, 2026
+9 −1
Merged

fix: add back in verifyTransaction #8907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/abstract-utxo/src/transaction/descriptor/verifyTransaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ export async function verifyTransaction<TNumber extends number | bigint>(
);
}

assertValidTransaction(psbt, descriptorMap, params.txParams.recipients ?? [], coin.name);

const parsedOutputs = toBaseParsedTransactionOutputsFromPsbt(
psbt,
descriptorMap,
Expand Down
8 changes: 7 additions & 1 deletion modules/abstract-utxo/test/unit/transaction/descriptor/verifyTransactionQr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import assert from 'assert';
import * as testutils from '@bitgo/wasm-utxo/testutils';

import { verifyTransaction } from '../../../../src/transaction/descriptor/verifyTransaction';
import { toExtendedAddressFormat } from '../../../../src/transaction/recipient';
import { getUtxoCoin } from '../../util';

const { getDefaultXPubs, getDescriptor, getDescriptorMap, mockPsbt } = testutils.descriptor;
Expand Down Expand Up @@ -44,12 +45,17 @@ describe('descriptor verifyTransaction - quantum-resistant sweep', function () {

it('should reject when external outputs exist and qr is true', async function () {
const psbt = buildPsbtWithExternal();
const externalScript = Buffer.from(descriptorOther.atDerivationIndex(0).scriptPubkey());
const externalAddress = toExtendedAddressFormat(externalScript, 'tbtc');

await assert.rejects(
verifyTransaction(
coin,
{
txParams: { qr: true, recipients: [] },
txParams: {
qr: true,
recipients: [{ address: externalAddress, amount: '400000' }],
},
txPrebuild: { txHex: Buffer.from(psbt.serialize()).toString('hex') },
wallet: {} as any,
},
Expand Down
Loading