Orders: show the Activity-linked order even when the list hides it - #115
Merged
BitcoinErrorLog merged 3 commits intoSep 24, 2026
Merged
Conversation
…list it An Activity row links to /marketplace/orders#order-<id>. A seller's checkout that was cancelled before payment is in no Orders section, so the link landed on a page without its order. When the hash names such an order, a From Activity card now shows it with its state (Cancelled before payment, Awaiting payment, ...) and short order ID, and the page scrolls to it. The hash is followed while the page is open.
…'s orders The fallback card rendered any loaded order the hash named. It now requires the signed-in pubky to be that order's buyer or seller, like every other Orders section, and renders nothing otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An Activity row links to
/marketplace/orders#order-<id>. The Orders page lists buyer checkouts, seller reservations, paid or receipted history, and buyer-abandoned checkouts. A seller's checkout that was cancelled before payment belongs to none of those, so the link opens a page that does not show its order.In production on Shop v0.6.26, the seller test seat
n3pfudgx…has 31 Activity order rows across 25 orders. Every one of them is an unpaid order,cancelledorpending_payment, from buyertjtigrhb…. The Orders page rendered none of them, only the held reservationOrder f0548768. This has been the case since v0.6.25 (#104/#105).Change
#order-<id>names an order the page loaded but lists in no section, a From Activity card shows that order. The card has the role badge (Your sale / Your purchase), a state badge, the line titles, and the short order ID with Copy. The page scrolls to the card.unlistedOrderStateLabelincheckout-phase.ts: "Cancelled before payment" (cancelled with no receipt), "Awaiting payment" (pending_payment), and otherwise the state name in sentence case.hashchange, so opening a second Activity link while Orders is open also works.b907ed08:PREPUSH OK b907ed08060329dbdb089a52b9cdba93d402fff0 453. It ran typecheck, 185 related unit tests, and 204 Linux VRT scenes across 9 specs. No baseline changed.Tests
MarketplaceOrders.test.tsxadds four tests: an unpaid seller cancel linked by hash (card, state, short ID, anchor id, scroll target); the same order without a hash (not rendered); a listed order linked by hash (no duplicate card); and ahashchangewhile the page is open.checkout-phase.test.tsadds label cases.MarketplaceOrders.tsxto56ccc6e5fails the card test and the hash-change test (2 of 39), and the fix passes all 39.MarketplaceOrders.vrt.test.tsxadds the scenesorders-activity-linked-unlisted-{desktop,mobile}. Their Linux baselines (Chromium and Firefox) come from the pinnedmcr.microsoft.com/playwright:v1.60.0-noblecontainer with--update=new, so no existing baseline changed. Calibration: the four PNGs have distinct md5s and are 43–55 KB each. Both viewed frames show "From Activity", "Your sale", "Cancelled before payment", "Brass desk lamp × 1" and "Order 018f47d2" above Reservations. Negative check: appending one byte to the desktop Chromium PNG fails the scene, and restoring it passes.Gate
PREPUSH OK 548ff8f2310d5cc3bed48da0032bba3818430eaa 815. It ran prettier and eslint on the changed files,npm run typecheck,vitest related(14 files, 184 tests), and Linux VRT for the 9 specs that render a changed file (18 files, 204 tests).Release note
changelog.d/next/activity-hidden-order.fixed.mdTester notice: reload is enough (no Dexie change).