Remove Shop production warning banners and auth capability dumps - #76
Merged
BitcoinErrorLog merged 9 commits intoSep 22, 2026
Merged
Conversation
Drop unsolicited maturity and real-money amber callouts from checkout, orders, and seller payment settings. Staging keeps the test-rails notice. Awaiting payment keeps a single muted hold sentence. Sign-in and grant QR dialogs no longer dump capability paths.
The QR no longer dumps capability paths. Auction bid step-up now asserts the plain Shop sentence instead of the old permission-list copy.
…lines Point the awaiting-payment method-picker scene at production so it proves the Real money amber is gone and only the muted hold sentence remains. Commit regenerated darwin baselines for cart, messaging, payment settings, Locks awaiting-start, and session-connect.
Awaiting payment shows only the muted hold sentence, with no Real money amber. Darwin and linux method-picker scenes were deleted and recorded fresh so the 2% marketplace comparator cannot hide the copy change.
Paykit setup Step 2 and the Connect Bitkit dialog now carry a muted helper: Shop identity must live in Bitkit, and Ring import is not available yet.
…aselines Step 2 and the Connect Bitkit dialog gained a muted Ring-identity helper. Darwin and linux scenes that include that copy are rerecorded; extras were not kept.
…/merge-seq-76-8b74 # Conflicts: # src/components/organisms/Marketplace/MarketplaceSessionConnectDialog.tsx
…/merge-seq-76-8b74 # Conflicts: # src/components/templates/Marketplace/MarketplaceCart.tsx # src/test/vrt/marketplace/__screenshots__/MarketplaceCart.vrt.test.tsx/cart-locks-paykit-desktop-chromium-darwin.png # src/test/vrt/marketplace/__screenshots__/MarketplaceCart.vrt.test.tsx/cart-locks-paykit-desktop-firefox-darwin.png # src/test/vrt/marketplace/__screenshots__/MarketplaceCart.vrt.test.tsx/cart-locks-paykit-desktop-webkit-darwin.png
BitcoinErrorLog
marked this pull request as ready for review
September 22, 2026 08:21
Copy the 17 *-actual-*-linux.png files from Marketplace VRT run 35704148854 onto the matching __screenshots__ linux baselines so vrt-marketplace matches the current session-connect, cart, messaging, payment-settings, and payment-status scenes after the #73 merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge. Inventory of disclaimer/warning copy on Shop marketplace surfaces, plus removal of OUR unsolicited banners and auth QR capability-path dumps.
Removed (ours)
2fd94c9dd8Bitcoin Error Log 2026-08-207a7a3c00a/014774c89holderUnboundCopyc213ae9f362026-09-08e2975e6dd62026-09-05c213ae9f36/13c13da94Kept
getDeployEnv() === 'staging'Added helper (Paykit Step 2)
Muted paragraph on Seller Studio Paykit setup Step 2 and the Connect Bitkit dialog (not a warning box):
Bitkit import of Ring identities is synonymdev/bitkit-android#1109, not in Bitkit master. Same guidance + Bitkit QR workaround posted on marketplace#53.
Not ours — leave
Grep
Real money/Choose how to pay/pays the seller directlyare gone fromsrc/product surfaces.never holds fundsremains only on the guarantee checkbox accept-terms inMarketplaceCart.tsx.VRT
Rerecorded for this helper:
payment-settings-bitkit-dialog-mobile(darwin chromium/firefox/webkit + linux chromium/firefox) andpayment-settings-display-preferences-desktop(Step 2 is in that frame). Path argument does not isolate--update; extras were reverted.