feat(tx-manifest): validate semantics and finalized intent - #15
Open
lukachi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack position
PR 6 of 9 in the txManifest release train.
Base: feature/tx-manifest-assets (PR #14)
This slice makes the reviewed plan reject what it cannot establish and verifies that the finalized Elements transaction is the transaction the wallet agreed to build. Later PRs add the inspector, confirmation UI, and application activation.
What changes
Review guide
Verification
Clean detached checkout at commit 30d0e44 with smplx 8f0215c (SDK 0.0.10) and LWK 693c4fb:
Deliberately excluded
The bundle remains open until the full train is delivered.