Fix email nested in link text, add some basic tests#21
Open
teppokoivula wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Roope, sorry! I didn't test previous PR well enough. Found an issue with nested emails.
Things looked fine at first glance, but actually...
... resulted in something like this:
This should now be fixed in this PR.
Also, since this is actually a tiny bit complicated, I thought it might make sense to bundle in some basic tests.
testObfuscation($html)can be used for one-off tests, and testObfuscationWithCases() runs some predefined test cases. Feel free to discard this part if you don't like the idea, but it helped me a lot while testing different situations :)Test results are an array like this:
And without this fix, two of the tests would fail: