ENH: Algorithm dispatch for OoOC filter optimizations#1545
Merged
imikejackson merged 1 commit intoMar 5, 2026
Merged
Conversation
joeykleingers
force-pushed
the
worktree-identify-sample-optimizations
branch
2 times, most recently
from
February 24, 2026 18:43
1bda2d9 to
c88c7f6
Compare
imikejackson
requested changes
Feb 24, 2026
imikejackson
left a comment
imikejackson
left a comment
Contributor
There was a problem hiding this comment.
As we discussed, there needs to be a clear path to exercise both code paths even with out-of-core is not being built. This PR should not be merged until this is figured out.
joeykleingers
force-pushed
the
worktree-identify-sample-optimizations
branch
2 times, most recently
from
February 28, 2026 18:42
fb7dd1b to
8e79b9c
Compare
joeykleingers
force-pushed
the
worktree-identify-sample-optimizations
branch
from
February 28, 2026 18:43
8e79b9c to
fd57058
Compare
joeykleingers
changed the title
joeykleingers
force-pushed
the
worktree-identify-sample-optimizations
branch
from
February 28, 2026 19:57
fd57058 to
4e6e1f6
Compare
joeykleingers
marked this pull request as draft
February 28, 2026 20:02
joeykleingers
changed the title
joeykleingers
force-pushed
the
worktree-identify-sample-optimizations
branch
from
February 28, 2026 20:03
4e6e1f6 to
9004622
Compare
joeykleingers
force-pushed
the
worktree-identify-sample-optimizations
branch
from
March 2, 2026 20:15
9004622 to
4070458
Compare
joeykleingers
force-pushed
the
worktree-identify-sample-optimizations
branch
from
March 4, 2026 19:04
8cc58af to
78aaf20
Compare
joeykleingers
changed the title
5 tasks
joeykleingers
changed the title
joeykleingers
marked this pull request as ready for review
March 4, 2026 19:28
joeykleingers
force-pushed
the
worktree-identify-sample-optimizations
branch
2 times, most recently
from
March 4, 2026 19:32
1204f12 to
0cf3dee
Compare
Add reusable AlgorithmDispatch.hpp utility with IsOutOfCore(), AnyOutOfCore(), ForceOocAlgorithm(), ForceOocAlgorithmGuard, and DispatchAlgorithm<InCore, OOC>() so filters can dispatch to separate in-core and out-of-core algorithm implementations at runtime. Includes documentation in docs/AlgorithmDispatch.md. No filters are using this infrastructure yet — it is provided as reusable scaffolding for future OOC optimization work.
joeykleingers
force-pushed
the
worktree-identify-sample-optimizations
branch
from
March 4, 2026 19:32
0cf3dee to
6d65499
Compare
4 tasks
imikejackson
changed the title
imikejackson
approved these changes
Mar 4, 2026
imikejackson
left a comment
imikejackson
left a comment
Contributor
There was a problem hiding this comment.
Somewhere in there is probably a way to use constexpr to compile out some of the logic but lets get this in.
imikejackson
enabled auto-merge (squash)
March 4, 2026 22:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AlgorithmDispatch.hpputility (IsOutOfCore,AnyOutOfCore,DispatchAlgorithm) for dispatching between in-core and OOC algorithm implementations at runtimeForceOocAlgorithm()static flag andForceOocAlgorithmGuardRAII class so unit tests can exercise the OOC algorithm path even in in-core buildsdocs/AlgorithmDispatch.md) explaining when and how to use algorithm dispatchFiles Changed
src/simplnx/Utilities/AlgorithmDispatch.hpp— Runtime dispatch utilitiesdocs/AlgorithmDispatch.md— Usage documentationCMakeLists.txt— Add header to buildTest Plan