Skip to content

fix: surface card network on Apple Pay and Google Pay results #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arstiefel merged 1 commit into from
Apr 28, 2026
Merged

fix: surface card network on Apple Pay and Google Pay results #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/__tests__/ApplePay.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ describe('ApplePay (native mode)', () => {
token: 'bolt_tok_abc',
bin: '411111',
expiration: '2027-12',
network: 'visa',
billingContact: rawNativeResponse.billingContact,
});
expect(onError).not.toHaveBeenCalled();
Expand Down
1 change: 1 addition & 0 deletions src/__tests__/GoogleWallet.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ describe('GoogleWallet', () => {
bin: '411111',
expiration: '2027-12',
last4: '1234',
network: 'visa',
email: 'jane@example.com',
billingAddress: rawNativeResponse.billingAddress,
});
Expand Down
1 change: 1 addition & 0 deletions src/payments/ApplePay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ const ApplePayNative = ({
token: tokenResult.token,
bin: tokenResult.bin,
expiration: tokenResult.expiry,
network: tokenResult.network,
billingContact: raw.billingContact,
};
success = true;
Expand Down
1 change: 1 addition & 0 deletions src/payments/GoogleWallet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ export const GoogleWallet = ({
bin: tokenResult.bin,
expiration: tokenResult.expiry,
last4: tokenResult.last4,
network: tokenResult.network,
email: raw.email,
billingAddress: raw.billingAddress,
};
Expand Down
2 changes: 2 additions & 0 deletions src/payments/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ export type GooglePayButtonTheme = 'dark' | 'light';
export interface ApplePayResult {
token: string;
bin?: string;
network?: string;
expiration?: string;
billingContact?: ApplePayBillingContact;
/**
Expand Down Expand Up @@ -168,6 +169,7 @@ export interface GooglePayResult {
token: string;
bin?: string;
last4?: string;
network?: string;
Comment on lines 126 to +172
Copy link
Copy Markdown
Contributor

@SanthoshCharanBolt SanthoshCharanBolt Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

 export interface TokenizeApplePayResult {
   token: string;
   expiry: string;
   last4: string;
   bin: string;
   network: CardType;
 }
 
 export interface TokenizeGooglePayResult {
   token: string;
   expiry: string;
   last4: string;
   bin: string;
   network: CardType;
 }

Copy link
Copy Markdown
Contributor

@SanthoshCharanBolt SanthoshCharanBolt Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these will be available all the time, they won't be undefined

expiration?: string;
email?: string;
billingAddress?: GooglePayBillingAddress;
Expand Down
Loading