Enhancement to "discover" tab.

I reopened Issue #2 this morning as I had a "eureka" moment when it came to resolving part 3 of the issue. Now, providing you use the DPDiscover suggested "hostname" and "description", it should change the "protocol" column entry and "Add" button to the word "ADDED".

Works for me - if it's reported as buggy, I'll rerelease 1.51 with the fixes.

I'll remove the "prerelease" indicator either in a few days or when someone else says it works as desired.

Fixes to the "discover" tab add function

The "Add" button in the dpdiscover.php file just sends you to the Cacti host.php to add the device. However, it wasn't following DPDiscover's settings before passing that data to the host.php, nor was it pulling additional information that should be available in the Cacti settings. 1.50 resolves these oversights for "Hostname vs IP", "FQDN vs Short Name", "Ping Timeout" and "Ping Retries".

Thank you Fabrice35 for letting me know about these (and other) issues in a portion of the plugin that I never bothered to play too much with.

Discover Source Filter

Added a requested feature for the "discover" tab - the ability to filter on a discovery protocol source (IE, see only CDP discovered hosts).

1.48: Fix to "discover" tab

This is what happens when you steal ... Er, borrow ... code from someone else.

I never made much use of the "discover" tab - it's held over from the "Auto Discovery" plugin that DPDiscover was based on. However, a user of DPDiscover noticed some issues and sent in a note. I've fixed the issue and it rates a new release.

Fix bug that became obvious with PHP 5.4.x

A line in findhosts.php was't needed (I think), so it was edited out. The line was erroneously attempting to take an existing string, index it by string (WTF?), and then assign that a value. Best case, the existing string should have been replaced.

In any event, the line was removed. Hopefully there won't be any other issues popping up.

Timing Tweaks

The development site runs polls every minute, and DPDiscover is scheduled for a daily run. Due to variances in the number of devices and processing power for a given Cacti server, the DPDiscover runs would "drift", starting later and later every day. A minor annoyance, but enough of one to where I fixed it. Kind of.

Now, when recording the start time of the previous run in the database, the time is recorded with a "minute" figure based on the "Start Time For Polling". So even if the poll ends up actually starting at 8:00:03am, it's recorded as 8:00:00am. Or, if for some reason (like drifting had been occurring and you upgrade), and polling started at 8:59:39am, it will be recorded in the DB as having started at 8:00:00am, and the next poll for a daily schedule will start at or just after 8:00:00am the next day. If the Frequency is set for 4 hours, it would run at or just after 12:00:00pm (and the next "last run start time" would be recorded as 12:00:00pm).

Sanity Checks

DPDiscover will log an error and exit if certain things (like DPDiscover Templates, known hosts) don't exist. The doco on my blog has been updated with a few explanations, adding information about what you need to do before letting the scans run.

There will likely be more checks added in later versions as others let me know just where they failed to read my mind.

Added exclusions for disabled hosts

Previously, disabled hosts (which should probably not be checked for anything, much less discovery protocol data) were treated like any other. In this version, they are read in only for ensuring there aren't any duplicate hosts out there.