Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements image support for recipes and adds user profile management features (email and password updates). The changes span both frontend and backend, including database schema modifications, API endpoints, and UI components.
- Add image support for recipe entities with storage and retrieval endpoints
- Implement user profile management with email and password update functionality
- Refactor exception handling by renaming UserLoginException to UserAuthenticationException for broader use
- Update database schema to include image_name field in recipe table
Reviewed changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/src/models/domain/RecipeSummary.ts | Add imageName field to recipe summary TypeScript model |
| ui/src/components/RecipeSummaryList.vue | Minor formatting change - move comment inline with type declaration |
| ui/src/components/RecipeSummary.vue | Add recipe image thumbnail display with conditional rendering based on imageName |
| ui/src/components/ProfileView.vue | Add extensive UI for updating user email and password with forms, validation, and error handling |
| ui/src/api/userApi.ts | Create new API functions for fetching and updating user email and password |
| ui/src/api/httpClient.ts | Export API_BASE_URL and remove trailing slash for consistency |
| docker-compose.yml | Add Docker volume mapping for recipe images storage |
| app/src/test/java/dev/blaauwendraad/recipe_book/service/UserAuthenticationTest.java | Update test to use renamed UserAuthenticationException |
| app/src/main/resources/db/migration/V1.2__create_recipe_table.sql | Add image_name column to recipe table schema |
| app/src/main/resources/db/dev-data/V2.2__insert_recipes.sql | Update test data to include image_name values |
| app/src/main/java/dev/blaauwendraad/recipe_book/web/model/UpdatePasswordRequest.java | Create request DTO for password update with validation |
| app/src/main/java/dev/blaauwendraad/recipe_book/web/model/UpdateEmailRequest.java | Create request DTO for email update with validation |
| app/src/main/java/dev/blaauwendraad/recipe_book/web/model/SaveRecipeRequestDto.java | Add imageName field and remove duplicate @NotNull annotation from numServings |
| app/src/main/java/dev/blaauwendraad/recipe_book/web/model/RecipeSummaryDto.java | Add imageName field to recipe summary DTO |
| app/src/main/java/dev/blaauwendraad/recipe_book/web/model/RecipeDto.java | Add imageName field to recipe DTO |
| app/src/main/java/dev/blaauwendraad/recipe_book/web/UserResource.java | Create new REST resource for user operations (get/update email and password) |
| app/src/main/java/dev/blaauwendraad/recipe_book/web/UserAuthenticationResource.java | Update to use renamed UserAuthenticationException |
| app/src/main/java/dev/blaauwendraad/recipe_book/web/RecipeResource.java | Add image retrieval endpoint and update create/update methods to handle imageName |
| app/src/main/java/dev/blaauwendraad/recipe_book/service/model/RecipeSummary.java | Add imageName field to service model |
| app/src/main/java/dev/blaauwendraad/recipe_book/service/model/Recipe.java | Add imageName field to service model |
| app/src/main/java/dev/blaauwendraad/recipe_book/service/exception/UserLoginException.java | Delete original exception class (renamed) |
| app/src/main/java/dev/blaauwendraad/recipe_book/service/exception/UserAuthenticationExceptionMapper.java | Update mapper to use renamed exception class |
| app/src/main/java/dev/blaauwendraad/recipe_book/service/exception/UserAuthenticationException.java | Create renamed exception for broader authentication use cases |
| app/src/main/java/dev/blaauwendraad/recipe_book/service/UserService.java | Create new service for user management operations |
| app/src/main/java/dev/blaauwendraad/recipe_book/service/UserAuthenticationService.java | Update to use renamed UserAuthenticationException |
| app/src/main/java/dev/blaauwendraad/recipe_book/service/RecipeService.java | Add imageName handling to recipe creation and updates |
| app/src/main/java/dev/blaauwendraad/recipe_book/repository/RecipeRepository.java | Add imageName parameter to recipe persistence method |
| app/src/main/java/dev/blaauwendraad/recipe_book/data/model/RecipeEntity.java | Add imageName field to recipe entity |
| app/data/images/spaghett.jpg | Add sample recipe image file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/main/java/dev/blaauwendraad/recipe_book/web/RecipeResource.java
Outdated
Show resolved
Hide resolved
app/src/main/java/dev/blaauwendraad/recipe_book/web/UserResource.java
Outdated
Show resolved
Hide resolved
app/src/main/java/dev/blaauwendraad/recipe_book/web/RecipeResource.java
Outdated
Show resolved
Hide resolved
app/src/main/java/dev/blaauwendraad/recipe_book/web/model/SaveRecipeRequestDto.java
Show resolved
Hide resolved
app/src/main/java/dev/blaauwendraad/recipe_book/service/UserService.java
Outdated
Show resolved
Hide resolved
app/src/main/java/dev/blaauwendraad/recipe_book/service/UserService.java
Outdated
Show resolved
Hide resolved
… Garage S3 object storage in a separate container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.