cbor/bpv7: store native field values and harden CBOR containers - #1
Open
polybassa wants to merge 3 commits into
Open
cbor/bpv7: store native field values and harden CBOR containers#1polybassa wants to merge 3 commits into
polybassa wants to merge 3 commits into
Conversation
CBOR packet fields now keep Python-native internals instead of CBOR_Object wrappers, with explicit build/dissect item accounting so required and conditional fields cannot silently shift array positions. Indefinite-length decoding, AI 31 handling, CRC auto-calculation, DTN time, IPN EID normalization, and BundleV7.validate() follow the PR secdev#5075 fix plan; incomplete BPSec stubs are removed from this change. AI-Assisted: yes Co-authored-by: Cursor <cursoragent@cursor.com>
Required fields always report min_items=1, CBOR_NO_ITEM separates sequence end from null, semantic tags and packet children use real item counts, and BPv7 CRC helpers share inferred type-code context. Harden maps/simple values/UTF-8 chunks/ranges, DTN/EID guards, and add focused UTS coverage for the review matrix. AI-Assisted: yes Co-authored-by: Cursor <cursoragent@cursor.com>
Respect parent array item budgets, require one-item packet cardinality on dissect, enforce required/present map members, add value-level APIs for ARRAY_OF/SEQUENCE_OF of semantic tags, and cover the findings with UTS. AI-Assisted: yes Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBOR packet fields now keep Python-native internals instead of CBOR_Object wrappers, with explicit build/dissect item accounting so required and conditional fields cannot silently shift array positions. Indefinite-length decoding, AI 31 handling, CRC auto-calculation, DTN time, IPN EID normalization, and BundleV7.validate() follow the PR secdev#5075 fix plan; incomplete BPSec stubs are removed from this change.
AI-Assisted: yes