Repository navigation
fix(goal): reject runtime-only proof for ordinary completion claims (#281) - #286
Merged
ByBrawe merged 19 commits intoOct 27, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…he semantic requirement (#281)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7820396ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…t runtime-only completion (#281)
…e counters, to prove docs completion (#281)
…on from pure process cadence (#281)
…ier host evidence (#281)
…ated checks and deletion-only objectives (#281)
… verify deletion absence and recreation race (#281)
…ession expectations (#281)
…ession expectations (#281)
…ession expectations (#281)
…ring independent audit (#281)
github-actions
Bot
deleted the
fix/semantic-runtime-only-false-completion-20261027
branch
October 27, 2026 10:42
This was referenced Oct 27, 2026
ByBrawe
added a commit
that referenced
this pull request
Oct 27, 2026
…current main This maintenance mirror preserves exact contributor source/test blob hashes from muhammad-luay/opencode-goal@6e988e5, against Goal main including #286 and #287, without importing fork CI workflows. This is a *test branch*, not a PR merge or published release. Co-authored-by: muhammad-luay <muhammad-luay@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirmed source-level false-completion loophole
semanticVerifierHostEvidence()injectsgoal-runtime-turns-rNandgoal-runtime-progress-rNastrust=host, passed=true. The verifier may cite those valid IDs alone and sayproveneven for a generic work product objective such asimplement src/slug.js. PriorguardSemanticProcessResults()returned all non-N-turncases unchanged;applySemanticVerifierResultsthus marked a semantic requirement proven, makingcompleteGoalpotentially accept runtime counters as deliverable proof despite no artifact or check evidence. Existing transport test actually expected exactly this behavior. This is a real code path, though it has not yet been matched to the reporter's Oct 18 incident (#279).Fix
proventounknownunless it includes a host-corroborated file quote or explicitly referenced current passing host file/command evidence. Mere Goal-owned turns/workspace-mutation counts never suffice.exactly/at least N Goal turnsprocess requirements retain their host-runtime proof path and existing cadence guards.Merge criteria
Full Goal Windows/Linux tests, pinned OpenCode 2.1.4 native host (PR #285), restart/Goal+Loop coexistence and existing semantic process fixtures are green. No docs that claim all prior false-complete reports reproduced or fixed. Keep #281 open for durable artifact-hash closure receipts and a real field-shaped replay. Do not merge external #276 simultaneously without rebasing its verification results onto this gate.
References: #281, #279, #275 / PR #276.