Fix: Filename split across OS#50
Merged
ahongbynder merged 1 commit intoBynder:masterfrom Aug 5, 2025
JeffSerota:fix-filename-split
Merged
Fix: Filename split across OS#50ahongbynder merged 1 commit intoBynder:masterfrom JeffSerota:fix-filename-split
ahongbynder merged 1 commit intoBynder:masterfrom
JeffSerota:fix-filename-split
Conversation
The previous split did not work on Windows.
ahongbynder
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous split did not work on Windows, which uses \ instead of /. Updating to use the already imported os module and the built in basename functionality.