Skip to content

[FEAT] Add MacOS release#69

Open
F2011 wants to merge 11 commits intoBzero:masterfrom
F2011:master
Open

[FEAT] Add MacOS release#69
F2011 wants to merge 11 commits intoBzero:masterfrom
F2011:master

Conversation

@F2011
Copy link

@F2011 F2011 commented Feb 3, 2026

This PR adds a release for MacOS.

@F2011
Copy link
Author

F2011 commented Feb 3, 2026

At the moment, the pipeline runs on every commit on master. We may change this to run only on tags in the format "v\d+.\d+.\d+" (i.e. for every SemVer-version-number)

@F2011
Copy link
Author

F2011 commented Feb 3, 2026

Test runs can be inspected at my fork

@Bzero
Copy link
Owner

Bzero commented Mar 9, 2026

Thank you very much for this pull request. I am very very sorry that I only managed to review this now!

I think it is overall looking very nice. As releases are not automated at this point, I would disable that the pipeline runs automatically. Of course it may be a good idea to do this eventually.

Since I am not able to do this myself, can I ask how much you tested Typstwriter on MacOS? Most of the application should run seamlessly on any platform supported by Qt but there is some platform specific behavior which was not necessarily written with MacOS in mind. I am in particular thinking of these features:

@Bzero Bzero self-requested a review March 9, 2026 00:43
@F2011
Copy link
Author

F2011 commented Mar 11, 2026

I think it is overall looking very nice. As releases are not automated at this point, I would disable that the pipeline runs automatically. Of course it may be a good idea to do this eventually.

I agree.

@F2011
Copy link
Author

F2011 commented Mar 11, 2026

Thank you very much for this pull request. I am very very sorry that I only managed to review this now!

I think it is overall looking very nice. As releases are not automated at this point, I would disable that the pipeline runs automatically. Of course it may be a good idea to do this eventually.

Since I am not able to do this myself, can I ask how much you tested Typstwriter on MacOS? Most of the application should run seamlessly on any platform supported by Qt but there is some platform specific behavior which was not necessarily written with MacOS in mind. I am in particular thinking of these features:

* Location of the config and settings files (should probably be okay as the [platformdir package takes care of that](https://github.com/Bzero/typstwriter/blob/c4e89624dc3b5e5572c1636978648542c995619b/typstwriter/configuration.py#L11-L13)).

* The way the typst compiler is used in an separate [process](https://github.com/Bzero/typstwriter/blob/c4e89624dc3b5e5572c1636978648542c995619b/typstwriter/compiler.py#L248-L254).

* Interaction with the [filesystem](https://github.com/Bzero/typstwriter/blob/c4e89624dc3b5e5572c1636978648542c995619b/typstwriter/fs_explorer.py#L330-L376)  and the [clipboard](https://github.com/Bzero/typstwriter/blob/c4e89624dc3b5e5572c1636978648542c995619b/typstwriter/fs_explorer.py#L378-L413).

* [Opening an external program](https://github.com/Bzero/typstwriter/blob/c4e89624dc3b5e5572c1636978648542c995619b/typstwriter/util.py#L122)(used to open files and the settings file in an external editor).

Answered in an issue: #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants