CRDCDH-3782 Export aggregated validation results as XLSX#42
Merged
Conversation
#140 Bundle Size — 12.43MiB (+0.02%).7d4e173(current) vs 60e7d1d 3.7.0#139(baseline) Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch CRDCDH-3782 Project dashboard Generated by RelativeCI Documentation Report issue |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the aggregated validation results export from CSV to XLSX, aligning it with the existing expanded export approach and introducing a dedicated Excel builder for the aggregated output.
Changes:
- Added
AggregatedValidationResultsExcelBuilderto generate an aggregated XLSX workbook. - Updated
ExportValidationButtonto fetch all aggregated results viafetchAllDataand download an XLSX file. - Updated unit tests and Storybook expectations for XLSX export behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/frontend/src/components/ExportValidationButton/index.tsx | Switches aggregated export flow to build/download XLSX and updates messaging/docs accordingly. |
| apps/frontend/src/components/ExportValidationButton/index.test.tsx | Updates aggregated export mocks/expectations for paginated fetching and XLSX download. |
| apps/frontend/src/components/ExportValidationButton/index.stories.tsx | Updates tooltip expectation for the export button story. |
| apps/frontend/src/classes/AggregatedValidationResultsExcelBuilder.ts | New builder that produces an aggregated validation results workbook (Summary sheet). |
| apps/frontend/src/classes/AggregatedValidationResultsExcelBuilder.test.ts | New tests validating the generated workbook structure/content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR builds off of CRDCDH-3758 to migrate the aggregated export to a XLSX file.
Note
The remaining piece to this functionality is the expanded view node comparison tables, which will be a separate ticket. Everything else should be fully functional.
Change Details (Specifics)
Related Ticket(s)
CRDCDH-3782 (Task)
CRDCDH-3447 (US)