Skip to content

CRDCDH-3782 Export aggregated validation results as XLSX#42

Merged
Alejandro-Vega merged 3 commits into
3.7.0from
CRDCDH-3782
Jun 11, 2026
Merged

CRDCDH-3782 Export aggregated validation results as XLSX#42
Alejandro-Vega merged 3 commits into
3.7.0from
CRDCDH-3782

Conversation

@amattu2

@amattu2 amattu2 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Overview

This PR builds off of CRDCDH-3758 to migrate the aggregated export to a XLSX file.

Note

The remaining piece to this functionality is the expanded view node comparison tables, which will be a separate ticket. Everything else should be fully functional.

Change Details (Specifics)

  • Implement a new class to manage the aggregated XLSX file generation
  • Update tests and storybook accordingly

Related Ticket(s)

CRDCDH-3782 (Task)
CRDCDH-3447 (US)

@amattu2 amattu2 added this to the 3.7.0 milestone Jun 11, 2026
@amattu2 amattu2 requested a review from Copilot June 11, 2026 17:55
@relativeci

relativeci Bot commented Jun 11, 2026

Copy link
Copy Markdown

#140 Bundle Size — 12.43MiB (+0.02%).

7d4e173(current) vs 60e7d1d 3.7.0#139(baseline)

Warning

Bundle contains 51 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes
                 Current
#140
     Baseline
#139
No change  Initial JS 876.35KiB 876.35KiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 27.96% 6.13%
Change  Chunks 71(+1.43%) 70
Change  Assets 114(+0.88%) 113
Change  Modules 9002(+0.01%) 9001
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 295 295
No change  Duplicate Packages 50 50
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#140
     Baseline
#139
Regression  JS 9.91MiB (+0.02%) 9.91MiB
No change  IMG 1.72MiB 1.72MiB
No change  Fonts 805.07KiB 805.07KiB
No change  CSS 18KiB 18KiB

Bundle analysis reportBranch CRDCDH-3782Project dashboard


Generated by RelativeCIDocumentationReport issue

@amattu2 amattu2 review requested due to automatic review settings June 11, 2026 18:06
@amattu2 amattu2 requested a review from Copilot June 11, 2026 18:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the aggregated validation results export from CSV to XLSX, aligning it with the existing expanded export approach and introducing a dedicated Excel builder for the aggregated output.

Changes:

  • Added AggregatedValidationResultsExcelBuilder to generate an aggregated XLSX workbook.
  • Updated ExportValidationButton to fetch all aggregated results via fetchAllData and download an XLSX file.
  • Updated unit tests and Storybook expectations for XLSX export behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
apps/frontend/src/components/ExportValidationButton/index.tsx Switches aggregated export flow to build/download XLSX and updates messaging/docs accordingly.
apps/frontend/src/components/ExportValidationButton/index.test.tsx Updates aggregated export mocks/expectations for paginated fetching and XLSX download.
apps/frontend/src/components/ExportValidationButton/index.stories.tsx Updates tooltip expectation for the export button story.
apps/frontend/src/classes/AggregatedValidationResultsExcelBuilder.ts New builder that produces an aggregated validation results workbook (Summary sheet).
apps/frontend/src/classes/AggregatedValidationResultsExcelBuilder.test.ts New tests validating the generated workbook structure/content.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/frontend/src/components/ExportValidationButton/index.tsx
Comment thread apps/frontend/src/components/ExportValidationButton/index.tsx Outdated
@amattu2 amattu2 requested a review from Alejandro-Vega June 11, 2026 18:14
Base automatically changed from CRDCDH-3758-3759 to 3.7.0 June 11, 2026 18:40

@Alejandro-Vega Alejandro-Vega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works well

@Alejandro-Vega Alejandro-Vega merged commit a8ce1bb into 3.7.0 Jun 11, 2026
18 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-3782 branch June 11, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants