Skip to content

fix: Prevent queue_test from overwriting completed test status #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canihavesomecoffee merged 1 commit into from
Dec 28, 2025
Merged

fix: Prevent queue_test from overwriting completed test status #981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions mod_ci/controllers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1305,6 +1305,14 @@ def queue_test(gh_commit: Commit.Commit, commit, test_type, platform, branch="ma
add_customized_regression_tests(platform_test.id)

if gh_commit is not None:
# Check if test already has progress (started or completed)
# If so, don't overwrite the GitHub status with "Tests queued"
# This prevents the bug where a completed test gets its status overwritten
# when a later webhook triggers queue_test for the same commit
if len(platform_test.progress) > 0:
log.info(f"Test {platform_test.id} already has progress, not posting 'Tests queued' status")
return

target_url = url_for('test.by_id', test_id=platform_test.id, _external=True)
status_context = f"CI - {platform_test.platform.value}"
update_status_on_github(gh_commit, Status.PENDING, "Tests queued", status_context, target_url)
Expand Down