Skip to content

1686: Repairing bugs with apply style feature - #1793

Open
glstott wants to merge 3 commits into
CDCgov:devfrom
glstott:1686-apply_style
Open

glstott wants to merge 3 commits into
CDCgov:devfrom
glstott:1686-apply_style

Conversation

@glstott

@glstott glstott commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #1686 by making applied style files restore the complete 2D network presentation:

  • Recalculate node-size scaling from the currently visible network so degree-based sizing remains accurate after filtering and timeline updates.
  • Wait for the network refresh before restoring groups, group positioning, group colors, and the group color table.
  • Apply saved distance metric, link sort field, and link threshold values to the active controls and filtering model so the imported threshold immediately filters the network.
  • Add regression coverage for combined degree sizing and grouping restoration, imported threshold behavior, and more reliable PrimeNG control interactions.

Scope expansion

The original report focused on degree sizing and the missing grouping color table. Investigation showed both were symptoms of broader style-application ordering and state-synchronization problems. Because a style file also stores filtering settings—and those settings determine the visible nodes used for sizing and grouping—the fix was expanded to restore the saved metric, link field, and threshold as part of the same operation. This keeps the rendered network consistent with the complete imported style rather than correcting only the two visible symptoms.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MT DEV: Apply style not perfect

1 participant