fix: resolve absolute package imports when pytest runs from repo root - #58
Merged
Merged
Conversation
Since the traffic-profile relocation (f99e8c3), performance tests import their profiles via absolute package paths (suricata_pytests.assets...). pytest is launched from inside this directory (pytest_start.sh), which puts the directory itself - not its parent - on sys.path, so collection fails with ModuleNotFoundError: No module named 'suricata_pytests'. Insert the parent directory into sys.path from conftest.py so the package resolves regardless of the invocation directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the traffic-profile relocation (f99e8c3), performance tests import their profiles via absolute package paths (suricata_pytests.assets...). pytest is launched from inside this directory (pytest_start.sh), which puts the directory itself - not its parent - on sys.path, so collection fails with ModuleNotFoundError: No module named 'suricata_pytests'.
Insert the parent directory into sys.path from conftest.py so the package resolves regardless of the invocation directory.