Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The workflow uses an unsupported enable-cache input for astral-sh/setup-ruff@v3, which will break CI.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the GitHub Actions lint workflow to run Ruff directly via the astral-sh/setup-ruff action, avoiding a full Python dependency install and emitting GitHub-annotated lint output.
Changes:
- Replace
actions/setup-python+pip install -r requirements.txtwithastral-sh/setup-ruff@v3pinned to Ruff0.15.19. - Emit Ruff check output using GitHub’s annotation format (
--output-format=github). - Rename the job key from
linttoruff(workflow name remainslint).
File summaries
| File | Description |
|---|---|
| .github/workflows/lint.yml | Switches the lint CI job to install/run Ruff via setup-ruff and emit GitHub-annotated output. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
The PR description claims caching is enabled, but the workflow does not configure caching (and ruff-action@v4.1.0 has no cache input), so the implementation doesn’t match the stated behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
matyas7dub
left a comment
matyas7dub
left a comment
There was a problem hiding this comment.
LGTM
Feel free to force push the rebase onto this PR
Replace setup-python + full requirements.txt install with the setup-ruff action (pinned to 0.15.19, matching requirements.txt) with caching enabled. The lint job needs nothing but ruff, so this drops the lbr_trex_client/scapy/paramiko install chain, making the job faster and less prone to unrelated native build failures. Also emit check results in GitHub's annotation format.
astral-sh/setup-ruff does not exist (runner: repository not found) and enable-cache is not a valid input for the ruff action. Use the actual action astral-sh/ruff-action@v4.1.0, resolve the ruff version from requirements.txt via version-file, and pass args: --version so the setup step only installs instead of also running a check.
a8dad8c to
53d57c9
Compare
Replace setup-python + full requirements.txt install with the setup-ruff action (pinned to 0.15.19, matching requirements.txt). The lint job needs nothing but ruff, so this drops the lbr_trex_client/scapy/paramiko install chain, making the job faster and less prone to unrelated native build failures. Also emit check results in GitHub's annotation format.