Skip to content

Refactor/12375 v1 remove deprecated ifconfig tool - #24

Merged
KEIAHNY merged 1 commit into
mainfrom
12375-refactor-ifconfig-v1
Sep 22, 2026
Merged

KEIAHNY merged 1 commit into
mainfrom
12375-refactor-ifconfig-v1

Conversation

@KEIAHNY

@KEIAHNY KEIAHNY commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

PR Type

Enhancement


Description

  • Remove deprecated ifconfig binary dependency and CLI option

  • Replace interface up/down commands with ip link set

  • Add get_ip_stat helper in CPU affinity module

  • Update config files, query JSON, and README documentation


Diagram Walkthrough

flowchart LR
  A["Suriconf config"] -- "remove ifconfig-bin" --> B["Suriconf struct"]
  C["CLI argument -i"] -- "removed" --> B
  B -- "use ip_bin" --> D["af_packet_tuning"]
  D -- "ip link set up/down" --> E["NIC tuning script"]
Loading

File Walkthrough

Relevant files
Enhancement
5 files
argument.rs
Remove `ifconfig_bin` CLI argument option                               
+0/-4     
cpu_affinity.rs
Replace ifconfig key with ip in affinity module                   
+8/-5     
main.rs
Remove ifconfig executable validation check                           
+0/-7     
structures.rs
Remove `ifconfig` variant from Keys enum                                 
+0/-2     
yaml.rs
Replace ifconfig commands with ip link set                             
+5/-25   
Documentation
1 files
README.md
Remove ifconfig from required tools table                               
+0/-1     
Configuration changes
2 files
suriconf.json
Remove ifconfig query path entry                                                 
+0/-3     
suriconf.yaml
Remove ifconfig-bin configuration line                                     
+0/-1     

@KEIAHNY KEIAHNY self-assigned this Sep 22, 2026
@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@KEIAHNY
KEIAHNY merged commit b117eeb into main Sep 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant