fix warning message for YANG module revision ordering - #2547
Merged
Conversation
The [standard](https://datatracker.ietf.org/doc/html/rfc7950#section-7.1.9) says that: > [...] a new [revision] SHOULD be added in front of the revisions > sequence so that all revisions are in reverse chronological order The actual error message was misleading, saying that an older revision was found after a new revision. That is actually a correct order. The check was correct, but the error message should have said that the older revision was found *before* a newer one. We actually "fixed" our YANG models based on this diagnostic message, only to revert that later on.
jktjkt
added a commit
to CESNET/rousette
that referenced
this pull request
Aug 5, 2026
Bug: CESNET/libyang#2547 Change-Id: Ie96091b06b8eaa598208b904e016fe13aafa9cce
michalvasko
approved these changes
Aug 6, 2026
Member
|
True, sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard says that:
The actual error message was misleading, saying that an older revision was found after a new revision. That is actually a correct order. The check was correct, but the error message should have said that the older revision was found before a newer one.
We actually "fixed" our YANG models based on this diagnostic message, only to revert that later on.