Conversation
LYA_PREALLOC() documents COUNT as the new count of the array, but realloc() still sized it as the current count plus COUNT, the meaning of the removed LY_ARRAY_CREATE. Every growth, including each LYA_ADD(), allocated about twice the memory needed. The callers converted from LY_ARRAY_CREATE that append to a non-empty array kept passing only the number of added items and worked only thanks to the over-allocation. Pass the total count there. The array is also never shrunk below its current count, so the count cannot exceed the allocation, and the macro locals no longer shadow variables the COUNT expression may use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LYA_PREALLOC()documentsCOUNTas the new count of the array, butrealloc()still computed the size as the current count plusCOUNT, so every growth allocated about twice the memory needed.The callers that append to a non-empty array passed only the number of added items and relied on the over-allocation. They now pass the total count. The array is never shrunk below its current count.