Open
Conversation
spjuhel
requested review from
chahank,
emanuel-schmid and
peanutfun
as code owners
peanutfun
reviewed
Mar 9, 2026
…roject/climada_python into 1260-fix-csr_matrix-type-check
peanutfun
reviewed
Mar 11, 2026
peanutfun
approved these changes
Mar 11, 2026
peanutfun
reviewed
Mar 26, 2026
| return sparse_coo.tocsr() # Convert sparse.COO to scipy.sparse.csr_array | ||
| return sparse.csr_matrix( | ||
| sparse_coo.tocsr() | ||
| ) # Convert sparse.COO to scipy.sparse.csr_array |
Member
There was a problem hiding this comment.
Suggested change
| ) # Convert sparse.COO to scipy.sparse.csr_array | |
| ) # Convert sparse.COO to scipy.sparse.csr_matrix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
tocsr()incsr_matrix()to enforce the type.This PR fixes #1260
See also #1255 and 5a6d536#diff-3175d04f0013b63b2662d6ced577cceeb7d458cc2a41d4711bbfff7f8577f0cbR61
PR Author Checklist
develop)PR Reviewer Checklist