forked from housseindjirdeh/angular2-hn
-
Notifications
You must be signed in to change notification settings - Fork 15
feature: migrate Angular 9 HN PWA to React + TypeScript on Vite #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
charityquinn-cognition
wants to merge
4
commits into
master
Choose a base branch
from
devin/1788163101-react-migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f5d6d24
feature: migrate Angular 9 HN PWA to React + TypeScript on Vite
devin-ai-integration[bot] dc1667e
bug: sanitize HN HTML, scope header styles, upgrade vulnerable deps
devin-ai-integration[bot] ac7bfb8
bug: pin CI Node to 20.19 and declare supported engines
devin-ai-integration[bot] 9d3330f
bug: narrow engines.node to Node releases supported by build deps
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| module.exports = { | ||
| root: true, | ||
| env: { browser: true, es2020: true }, | ||
| extends: [ | ||
| 'eslint:recommended', | ||
| 'plugin:@typescript-eslint/recommended', | ||
| 'plugin:react-hooks/recommended', | ||
| ], | ||
| ignorePatterns: ['dist', 'dev-dist', '.eslintrc.cjs'], | ||
| parser: '@typescript-eslint/parser', | ||
| plugins: ['react-refresh'], | ||
| rules: { | ||
| 'react-refresh/only-export-components': ['warn', { allowConstantExport: true }], | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,3 +44,6 @@ testem.log | |
| # System Files | ||
| .DS_Store | ||
| Thumbs.db | ||
|
|
||
| # Vite PWA dev output | ||
| /dev-dist | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,24 @@ | ||
| # Contributing | ||
|
|
||
| Thank you for your interest in contributing! Please feel free to put up a PR for any issue or feature request. | ||
| Even if you have little to no experience with Angular, I'll be more than happy to help. :) | ||
| Even if you have little to no experience with React, I'll be more than happy to help. :) | ||
|
|
||
| ## Setup | ||
|
|
||
| 1. Fork the repo | ||
| 2. Clone your fork | ||
| 3. Make a branch for your feature or bug fix | ||
| 4. If you don't have Angular CLI installed: `npm install -g angular-cli@latest` | ||
| 5. `ng init` | ||
| 6. Type `n` for each file to not overwrite any file changes | ||
| 7. Run `npm start` and open `localhost:4200` in a browser | ||
| 8. Work your magic | ||
| 9. Run `npm run build` or `npm run static-serve` to kick off a production build and make sure nothing is broken | ||
| 10. To test service worker changes: | ||
| 4. `npm install` | ||
| 5. Run `npm run dev` and open `localhost:4200` in a browser | ||
| 6. Work your magic | ||
| 7. Run `npm run lint`, `npm test` and `npm run build` to make sure nothing is broken | ||
| 8. To test service worker changes: | ||
| * `npm run build` to kick off a fresh build and update the `dist/` directory | ||
| * `npm run precache` to generate the service worker file | ||
| * `npm run static-serve` to load the application along with the service worker asset using [live-server](https://github.com/tapio/live-server) | ||
| 11. Add yourself to the [contributor's list](https://github.com/hdjirdeh/angular2-hn#contributors) in the README! | ||
| 12. Commit your changes and reference the issue you're addressing (for example: `git commit -am 'Commit message. Closes #5'`) | ||
| 13. Push your branch to your fork | ||
| 14. Create a pull request from your branch on your fork to `master` on this repo | ||
| 15. Have your branch get merged in! :star2: | ||
| * `npm run preview` to serve the built app together with its generated service worker | ||
| 9. Add yourself to the [contributor's list](https://github.com/hdjirdeh/angular2-hn#contributors) in the README! | ||
| 10. Commit your changes and reference the issue you're addressing (for example: `git commit -am 'Commit message. Closes #5'`) | ||
| 11. Push your branch to your fork | ||
| 12. Create a pull request from your branch on your fork to `master` on this repo | ||
| 13. Have your branch get merged in! :star2: | ||
|
|
||
| If you experience a problem at any point, please don't hesitate to file an issue or send me a message! | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Contributor credit remains missing
The contribution checklist requires adding the contributor to the README list. This pull request updates that checklist without adding its contributor.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist item is for human contributors; this migration PR is authored by Devin, so no contributor list entry was added.