MBA-2260: Migrate angular2-hn from Angular to React - #709
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
MBA-2260: Migrate angular2-hn from Angular to React#709devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuilds the Hacker News PWA client in React (Vite + React 18 + TypeScript + react-router-dom v6), replacing the Angular 9 app in-place with full feature parity (MBA-2260).
Mapping of the Angular pieces:
app.routes.ts→App.tsxroutes:/→/news/1, five feed routes (/news|newest|show|ask|jobs/:page), lazy-loaded/item/:idand/user/:id(mirrors the Angular lazy modules).HackerNewsAPIService→src/services/api.ts: samenode-hnapi.herokuapp.comendpoints, poll-option aggregation preserved (poll_votes_count), Observable cancel-token replaced withAbortController.SettingsService→SettingsContext: identical localStorage keys/defaults (theme,titleFontSize,listSpacing,openLinkInNewTab) and the sameprefers-color-schemebehavior (system dark →nightonly when no saved theme).src/styles/with only selector-level adaptations (e.g.app-root:empty→#root:emptypre-boot loader).ngsw-config.json→vite-plugin-pwa(Workbox): precached build assets, NetworkFirst runtime cache for the HN API, manifest values (name, icons, colors) carried over unchanged — offline support and installability maintained.vite preview.npm run lint,npm run test,npm run build, andnpm run e2eall pass.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/0cd6012fc20043e6a844383c1371fee5
Open in Devin Desktop: https://app.devin.ai/desktop/session/0cd6012fc20043e6a844383c1371fee5?variant=devin
Devin Review