Use vueuse useToggle instead of local composable#154
Open
mirumodapon wants to merge 1 commit into
Open
Conversation
Dokploy Preview Deployment
|
There was a problem hiding this comment.
Pull request overview
This PR removes the project’s local useToggle composable and switches CpPopup to use useToggle from @vueuse/core, reducing duplicated utility code and standardizing on VueUse helpers already in use.
Changes:
- Deleted
app/composables/useToggle.ts(local toggle composable). - Updated
CpPopup.vueto import and useuseTogglefrom@vueuse/core, including a close helper and click handler wiring.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/composables/useToggle.ts | Removes the local toggle composable in favor of VueUse’s implementation. |
| app/components/shared/CpPopup.vue | Replaces local toggle usage with @vueuse/core’s useToggle and adjusts click/close behavior accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
20
to
22
| name="trigger" | ||
| @click="toggle" | ||
| @click="() => toggle()" | ||
| /> |
rileychh
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.