Feature/248 refactor project structure

[MaartendeKruijf]

No description provided.

[github-actions]

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your Sigrid objective of 1.0 stars

Show details

Sigrid compared your code against the baseline of 2024-11-22.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

Unfortunately, 166 refactoring candidates were introduced or got worse.

Risk	System property	Location
🔴	Duplication (Introduced)	pkg/utils/stix/expression/comparison/comparison.go (lines 152-171) pkg/utils/stix/expression/comparison/comparison.go (lines 183-202)
🔴	Duplication (Introduced)	pkg/utils/stix/expression/comparison/comparison.go (lines 213-223) pkg/utils/stix/expression/comparison/comparison.go (lines 322-333)
🔴	Duplication (Introduced)	internal/validators/json.go (lines 13-26) pkg/models/validator/schema.go (lines 42-55)
🔴	Duplication (Introduced)	pkg/models/cacao/cacao.go (lines 280-292) pkg/models/decoder/decoder.go (lines 50-62)
🔴	Duplication (Introduced)	pkg/utils/stix/expression/comparison/comparison.go (line 213-220) pkg/utils/stix/expression/comparison/comparison.go (line 322-330) pkg/utils/stix/expression/comparison/comparison.go (line 183-191) + 1 occurrences
🔴	Duplication (Introduced)	pkg/core/capability/openc2/openc2.go (lines 42-48) pkg/core/capability/powershell/powershell.go (lines 48-54)
🔴	Duplication (Introduced)	pkg/core/capability/controller/controller.go (lines 104-110) pkg/core/capability/controller/controller.go (lines 132-138)
🔴	Duplication (Introduced)	pkg/integration/thehive/reporter/thehive_connector.go (lines 131-137) pkg/integration/thehive/reporter/thehive_connector.go (lines 70-76)
⚫️		+ 158 more

📚 Remaining technical debt

0 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid** to explore your technical debt

⭐️ Sigrid ratings

System property	System on 2024-11-22	Before changes	New/changed code
Volume	5.4	N/A	N/A
Duplication	4.4	N/A	4.4
Unit Size	2.5	N/A	2.9
Unit Complexity	2.6	N/A	2.6
Unit Interfacing	2.4	N/A	2.4
Module Coupling	3.8	N/A	3.8
Component Independence	5.4	N/A	N/A
Component Entanglement	2.4	N/A	N/A
Maintainability	3.7	N/A	3.3

---

Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.

• ✅ Yes, these findings are useful
• 🔸 The findings are false positives
• 🔹 These findings are not so important to me

---

View this system in Sigrid

[MaartendeKruijf]

Reporting docs will be updated in #235

[lucamrgs]

Looks really nice to me, thanks for this!
I have just pointed out one small typo in the docs, and a suggestion to move integration/thehive/reporter/ids_map.go to integration/thehive/common

[lucamrgs]

typo: ...will create all classeS

[lucamrgs]

I think this could go in the "common" directory, since probably a manual step implementation would also use the ids map

[MaartendeKruijf]

I think so too but I don't want to change the code at this point

[lucamrgs]

All good with me!