added soft reqs for accepting usb packets to contract actuators#1
Draft
mccombeerin wants to merge 8 commits into
Draft
added soft reqs for accepting usb packets to contract actuators#1mccombeerin wants to merge 8 commits into
mccombeerin wants to merge 8 commits into
Conversation
codeflight1
reviewed
Jul 3, 2026
| /* USER CODE BEGIN 3 */ | ||
| } | ||
| /* USER CODE END 3 */ | ||
| uint32_t current_time = HAL_GetTick(); |
Contributor
There was a problem hiding this comment.
This whole block of code should be after the declaration of the while loop but before the USER CODE END WHILE comment. The USER CODE END 3 comment also needs to be added back after the while loop.
codeflight1
requested changes
Jul 7, 2026
codeflight1
reviewed
Jul 9, 2026
codeflight1
reviewed
Jul 11, 2026
| RCC_ClkInitTypeDef RCC_ClkInitStruct = {0}; | ||
| RCC_PeriphCLKInitTypeDef PeriphClkInit = {0}; | ||
|
|
||
| /** Initializes the RCC Oscillators according to the specified parameters |
Contributor
There was a problem hiding this comment.
Please don't remove autogenerated comments
codeflight1
requested changes
Jul 14, 2026
codeflight1
left a comment
codeflight1
left a comment
Contributor
There was a problem hiding this comment.
Getting close, left a comment on the CO2 reading and there are a couple others left over that should be resolved before merge.
codeflight1
requested changes
Jul 15, 2026
| uint16_t co2_ppm = 0; | ||
|
|
||
| // Read the active 16-byte frame from USART3 | ||
| if (HAL_UART_Receive(&huart3, rx_buf, 16, 1000) == HAL_OK) |
Contributor
There was a problem hiding this comment.
This will block since it is being called at 10hz, please call less often or move to the UART receive interrupt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.