Morse gstreamer#164
Open
TomasWilliston wants to merge 7 commits into
Open
Conversation
ConnorNeed
reviewed
Jul 9, 2026
| namespace { | ||
| constexpr gdouble kMinUnitSeconds = 0.015; | ||
| constexpr gdouble kMaxUnitSeconds = 1.2; | ||
| constexpr gdouble kMinTransitionUnits = 0.08; |
Member
There was a problem hiding this comment.
At 66.7ms dit length this corresponds to 5.336ms. Our fastest camera only gets 60fps of 16.67ms. We might have to ignore all debouncing and pray that with enough attempts we get a good enough picture.
ConnorNeed
reviewed
Jul 11, 2026
ConnorNeed
left a comment
ConnorNeed
left a comment
Member
There was a problem hiding this comment.
I don't think you need all these locks.
The streaming thread is single threaded so any object not changed in the set_params does not need protection. For params that don't need to be changed at runtime you can set them as GST_PARAM_MUTABLE_READY and then gstreamer won't let them change while the pipeline is ready
Comment on lines
+704
to
+705
| roi_x = self->roi_x; | ||
| roi_y = self->roi_y; |
Member
There was a problem hiding this comment.
Are these values expected to be different from line 694?
…led blinking more and one for parsing such an LED, along with helper modules and a test script.
TomasWilliston
force-pushed
the
morse-gstreamer
branch
from
65598ae to
a5811fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a gstreamer plugin (+ helper modules) for parsing morse code from a red blinking LED, as well as another plugin + python script for testing the detection without a camera.