feat: correct default IPs as constants#48
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes several previously hard-coded IP addresses into a single src/constants.ts module and updates UI components (and a route handler) to use these shared constants, reducing scattered “magic IPs” across the codebase.
Changes:
- Added
src/constants.tsto define shared IP/host defaults (e.g., rover/base AP/base host, tiling server). - Updated multiple UI components to use the new constants instead of inline IP strings or runtime env values.
- Simplified
start.shby removing local IP detection and no longer injectingNEXT_PUBLIC_TILE_SERVERinto the web UI container.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| start.sh | Removes local IP probing and stops passing tile-server address via env var to the web container. |
| src/constants.ts | Introduces centralized constants for rover/base/AP IPs and tiling server host:port. |
| src/components/panels/MosaicDashboard.tsx | Replaces hard-coded WebRTC signaling IP with ROVER_IP. |
| src/components/panels/MapView.tsx | Switches offline tile URL to use TILING_SERVER constant. |
| src/components/ContainerList.tsx | Sets default launch server base URL using ROVER_IP. |
| src/components/ContainerCard.tsx | Removes env-derived API base logic (but leaves an unused import). |
| src/components/ConnectionStatusDisplay.tsx | Updates default ROS bridge URL to use ROVER_IP. |
| src/app/dashboard/api/route.ts | Replaces hard-coded ping host list with constants. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ConnorNeed
force-pushed
the
prefill-all-ips
branch
from
July 13, 2026 21:33
2589e06 to
650f302
Compare
codeflight1
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid having random ips all over the place making it more readable and easier to update.
Gives us better defaults in a few places as well