-
Notifications
You must be signed in to change notification settings - Fork 0
The approver is a principal, and an approval says who verified them #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e578a22
The approver is a principal, and an approval says who verified them
arpanghoshal fd6cd7a
Answer the item 2 review: a gate that skipped, and an observe row tha…
arpanghoshal 9bea8c5
Answer round two: the deferral strands a reservation, so the lapsed r…
arpanghoshal 154a86f
Answer round three: a human's no was counted nowhere, and five paragr…
arpanghoshal 73fb387
Answer CodeRabbit: str is a Sequence, and four inaccuracies
arpanghoshal 9214a60
Say five where the table has five rows
arpanghoshal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Validate
entitledbefore converting it to a tuple_approvers_from_jsonpasses stored approver mappings toVerifiedApprover.from_dict. A string such as"abc"currently becomes("a", "b", "c"), so the corrupted approval row is accepted instead of raising the documentedCTRLRunError(InvalidArgument). Validate the raw value before conversion, while preserving an omitted ornullvalue as empty:🛡️ Proposed fix
`@classmethod` def from_dict(cls, document: Mapping[str, Any]) -> VerifiedApprover: + entitled = document.get("entitled") + if entitled is None: + entitled = () + elif not isinstance(entitled, (list, tuple)): + raise InvalidArgument( + f"a verified approver's 'entitled' must be a list, got {type(entitled).__name__}" + ) return cls( agent=str(document["agent"]), user=document.get("user"), issuer=document.get("issuer"), granted_at=datetime.fromisoformat(str(document["granted_at"])), - entitled=tuple(document.get("entitled") or ()), + entitled=tuple(entitled), )🤖 Prompt for AI Agents