🐛 fix(label_widget): prevent PyQt6 attribute panel crash#1337
Merged
CVHub520 merged 1 commit intoCVHub520:mainfrom Apr 18, 2026
Merged
🐛 fix(label_widget): prevent PyQt6 attribute panel crash#1337CVHub520 merged 1 commit intoCVHub520:mainfrom
CVHub520 merged 1 commit intoCVHub520:mainfrom
Conversation
Use QFontMetrics.horizontalAdvance() when available so loading shape attributes no longer crashes on PyQt6, and add regression coverage for both the Qt6 path and the legacy fallback. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
horizontalAdvance()path and the fallback pathTest plan
./.venv/Scripts/python.exe -m unittest tests.test_label_widget_metricslabel.txtandattribute.jsonno longer crashes the app