6.19: Add HID uniq sanitization fix#148
Open
LarsSoeMikkelsen wants to merge 1 commit intoCachyOS:masterfrom
Open
6.19: Add HID uniq sanitization fix#148LarsSoeMikkelsen wants to merge 1 commit intoCachyOS:masterfrom
LarsSoeMikkelsen wants to merge 1 commit intoCachyOS:masterfrom
Conversation
6.19: Add HID uniq sanitization fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some USB HID devices return a serial string from usb_string() containing control characters, which propagate as UNIQ= in the kernel uevent. This causes systemd-logind TakeDevice to fail with ENODEV for all associated input event devices, making the device non-functional at boot.
Sanitizes hid->uniq after the usb_string() call to strip non-printable characters. Generic fix — affects any HID device with control chars in its USB serial.
Refs: systemd/systemd#41296, https://bugzilla.redhat.com/show_bug.cgi?id=2448678