Add ASUS Aura 0x1B29 detector#86
Open
Komzpa wants to merge 1 commit intoCalcProgrammer1:masterfrom
Open
Conversation
d2e1e74 to
80cc818
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial commit for ASUS Aura USB controller
0x0B05:0x1B29.This adds PID
0x1B29for the ASUS ROG Strix LC III cooler RGB controller. The device uses the same ASUS Aura USB protocol as the already-supported mainboard controllers, so this reuses the existingAuraMainboardControllerprotocol implementation while registering the physical device asASUS ROG Strix LC IIIinstead of another motherboard PID.I verified this on Linux with real hardware:
0b05:1b29/dev/hidraw19876543210ASUS ROG Strix LC IIIAura Addressable 1Tested commands on the device:
The controller class still reports the existing mainboard category/description because this patch intentionally keeps the change small and reuses the known-good protocol implementation. If maintainers prefer, I can split a dedicated RGBController wrapper for the cooler label/category in a follow-up.
Build verification:
debian:sidDocker container withqmake OpenRGB.pro && make -j$(nproc).Checklist for Accepting a Merge Request for a New Device
masteris protected by default when creating a fork, so it is recommended to not use it as your source).New Deviceissue raised for this device is linked to this MR with a keywordCloses / Resolves / ImplementsNew Deviceissue to provide ongoing support.RGBController_*file/dev/hidraw1