Wake Render backend before embedded login - #22
Merged
Conversation
Add prepareEmbeddedLogin function to handle login preparation and backend readiness.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the embedded Xaman login flow by proactively waking a potentially cold Render backend (via a health/readiness probe) before attempting to create the login state, and adds a regression test to ensure the readiness step happens first.
Changes:
- Add
prepareEmbeddedLogin()to runwaitForBackendReady()beforestartLoginWithRetry()for embedded login. - Update the embedded login path in
XamanLoginPanelto use the new preparation function and show progress messaging during cold start. - Add a Node behavioral test that verifies backend readiness occurs before login-state creation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/tests/xaman_login_start_retry.test.mjs | Adds coverage asserting the embedded flow wakes the backend before calling login/start. |
| frontend/components/XamanLoginPanel.tsx | Introduces prepareEmbeddedLogin() and routes embedded login through it with a new “waking-up” progress phase. |
Suppressed comments (1)
frontend/components/XamanLoginPanel.tsx:623
- During the new "waking-up" phase, the UI message claims "Xaman is ready", but at this point we are only warming the backend (WordPress/Xaman preparation may still be in progress). This conflicts with the intent to show a cold-start message while WordPress prepares Xaman in parallel and can mislead users.
reason === "waking-up"
? "Xaman is ready. Starting the secure CalorieApp service. This can take about a minute. Keep this page open."
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification