Skip to content

Fix dry_run handling in publish job for scheduled runs#421

Merged
blink1073 merged 1 commit intoCalysto:mainfrom
blink1073:fix-nightly-publish
Mar 24, 2026
Merged

Fix dry_run handling in publish job for scheduled runs#421
blink1073 merged 1 commit intoCalysto:mainfrom
blink1073:fix-nightly-publish

Conversation

@blink1073
Copy link
Copy Markdown
Contributor

References

Relates to https://github.com/Calysto/metakernel/actions/runs/23481934503

Description

The publish job used inputs.dry_run directly, which is undefined (empty string) for schedule events. This caused the publish job to treat dry runs as real publishes on scheduled runs.

Changes

  • Expose effective dry_run as an output of the release job using the same ternary logic already used for the release step
  • Add release to publish's needs so the output is accessible
  • Replace all three inputs.dry_run references in publish with needs.release.outputs.dry_run

Backwards-incompatible changes

None

Testing

N/A

AI usage

  • Some or all of the content of this PR was generated by AI.
  • The human author has carefully reviewed this PR and run this code.
  • AI tools and models used: Claude Sonnet 4.6

@blink1073 blink1073 enabled auto-merge (squash) March 24, 2026 13:14
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (84f58d7) to head (ed70029).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #421   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files          51       51           
  Lines        2950     2950           
  Branches      414      414           
=======================================
  Hits         2664     2664           
  Misses        209      209           
  Partials       77       77           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blink1073 blink1073 merged commit 271e93a into Calysto:main Mar 24, 2026
24 checks passed
@blink1073 blink1073 deleted the fix-nightly-publish branch March 24, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant