Process backspaces in output to fix test on groff-1.23.0#422
Merged
blink1073 merged 1 commit intoCalysto:mainfrom Mar 24, 2026
Merged
Process backspaces in output to fix test on groff-1.23.0#422blink1073 merged 1 commit intoCalysto:mainfrom
blink1073 merged 1 commit intoCalysto:mainfrom
Conversation
Strip backspaces along with the preceding characters from `man sleep` output in tests, in order to normalize the output and make the test pass irrespective of groff version. Fixes Calysto#266 Signed-off-by: Michał Górny <mgorny@gentoo.org>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
=======================================
Coverage 90.30% 90.30%
=======================================
Files 51 51
Lines 2950 2950
Branches 414 414
=======================================
Hits 2664 2664
Misses 209 209
Partials 77 77 🚀 New features to boost your workflow:
|
Comment on lines
-36
to
+39
| res = bash.run_command("man sleep", timeout=2) | ||
| assert "SLEEP" in res, res | ||
| res = bash.run_command("NO_COLOR=1 man sleep", timeout=2) | ||
| # groff-1.23.0 uses backspaces in output. Strip them along with | ||
| # the preceding character to normalize the tested result. | ||
| assert "SLEEP" in re.sub(r".\x08", "", res), res |
There was a problem hiding this comment.
How about bash.run_command("NO_COLOR=1 man sleep | col -b", timeout=2)?
I don't know if pipes can be used there, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #266
Description
Strip backspaces along with the preceding characters from
man sleepoutput in tests, in order to normalize the output and make the test pass irrespective of groff version.Changes
See "description".
Backwards-incompatible changes
None
Testing
AI usage