Fix sdist test collection failure for dragon.py#423
Merged
blink1073 merged 2 commits intoCalysto:mainfrom Mar 25, 2026
Merged
Conversation
Exclude metakernel/images/*.py from pytest collection via collect_ignore_glob so dragon.py (a logo-generation script requiring optional Graphics/Myro packages) doesn't cause an ImportError during test collection.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
==========================================
+ Coverage 90.30% 90.81% +0.50%
==========================================
Files 51 51
Lines 2950 2950
Branches 414 414
==========================================
+ Hits 2664 2679 +15
+ Misses 209 190 -19
- Partials 77 81 +4 🚀 New features to boost your workflow:
|
conftest.py is not included in the sdist, so collect_ignore_glob had no effect. Setting norecursedirs = ["images"] in pyproject.toml (which is always present in the sdist) ensures dragon.py is never collected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
metakernel/images/dragon.pyis a logo-generation script that imports optionalGraphicsandMyropackages at the top level. During the sdist test, pytest was collecting it as a module (due to--doctest-modules), failing immediately withImportError: No module named 'Graphics'and interrupting the entire test run.Changes
collect_ignore_glob = ["metakernel/images/*.py"]toconftest.pyto exclude logo-generation scripts from pytest collectionBackwards-incompatible changes
None
Testing
The sdist test was failing with
Interrupted: 1 error during collection. This change prevents collection ofdragon.py.AI usage