Skip to content

fix: start processing after buffered MP4 recordings finish uploading #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richiemcilroy merged 3 commits into from
Jun 12, 2026
+56 −1
Merged

fix: start processing after buffered MP4 recordings finish uploading #1911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3a812a
fix(web-recorder): start processing after buffered MP4 recordings fin…
ManthanNimodiya Jun 11, 2026
724644f
fix(web-recorder): use authenticated user id for raw file key
ManthanNimodiya Jun 11, 2026
8d6482e
fix(process-video): skip raw upload cleanup when raw key matches outp…
ManthanNimodiya Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions apps/web/actions/video/trigger-instant-recording-processing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
"use server";

import { db } from "@cap/database";
import { getCurrentUser } from "@cap/database/auth/session";
import { videos } from "@cap/database/schema";
import type { Video } from "@cap/web-domain";
import { eq } from "drizzle-orm";
import { startVideoProcessingWorkflow } from "@/lib/video-processing";

export async function triggerInstantRecordingProcessing({
videoId,
}: {
videoId: Video.VideoId;
}): Promise<{ success: boolean }> {
const user = await getCurrentUser();
if (!user) throw new Error("Unauthorized");

const [video] = await db()
.select()
.from(videos)
.where(eq(videos.id, videoId));

if (!video) throw new Error("Video not found");
if (video.ownerId !== user.id) throw new Error("Unauthorized");

const rawFileKey = `${user.id}/${videoId}/result.mp4`;

await startVideoProcessingWorkflow({
videoId,
userId: user.id,
rawFileKey,
bucketId: video.bucket ?? null,
processingMessage: "Starting video processing...",
startFailureMessage: "Video uploaded, but processing could not start.",
mode: "singlepart",
});
Comment on lines +28 to +36

@greptile-apps greptile-apps Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 processVideoWorkflow deletes result.mp4 after processing

startVideoProcessingWorkflow calls processVideoWorkflow, which finishes with cleanupRawUpload(videoId, rawFileKey) — an unconditional bucket.deleteObject(rawFileKey). For the streaming-webm path rawFileKey is raw-upload.webm, a distinct intermediary that should be cleaned up. Here rawFileKey = "${user.id}/${videoId}/result.mp4", which is also the hardcoded outputKey written by the media server (${userId}/${videoId}/result.mp4 in process-video.ts line 255). After the media server successfully writes the transcoded output to result.mp4, cleanupRawUpload immediately deletes that same key, leaving the video unplayable.

The existing admin reprocess path (adminReprocessVideoWorkflow) handles exactly this case — it calls the media server in the same way but has no cleanup step. Either route through that workflow, or guard the cleanup in processVideoWorkflow so it skips deletion when rawFileKey equals the output key.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: apps/web/actions/video/trigger-instant-recording-processing.ts
Line: 28-36

Comment:
**`processVideoWorkflow` deletes `result.mp4` after processing**

`startVideoProcessingWorkflow` calls `processVideoWorkflow`, which finishes with `cleanupRawUpload(videoId, rawFileKey)` — an unconditional `bucket.deleteObject(rawFileKey)`. For the streaming-webm path `rawFileKey` is `raw-upload.webm`, a distinct intermediary that should be cleaned up. Here `rawFileKey = "${user.id}/${videoId}/result.mp4"`, which is also the hardcoded `outputKey` written by the media server (`${userId}/${videoId}/result.mp4` in `process-video.ts` line 255). After the media server successfully writes the transcoded output to `result.mp4`, `cleanupRawUpload` immediately deletes that same key, leaving the video unplayable.

The existing admin reprocess path (`adminReprocessVideoWorkflow`) handles exactly this case — it calls the media server in the same way but has no cleanup step. Either route through that workflow, or guard the cleanup in `processVideoWorkflow` so it skips deletion when `rawFileKey` equals the output key.

How can I resolve this? If you propose a fix, please make it concise.


return { success: true };
}
12 changes: 12 additions & 0 deletions apps/web/app/(org)/dashboard/caps/components/web-recorder-dialog/useWebRecorder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { Cause, Exit, Option } from "effect";
import { useRouter } from "next/navigation";
import { useCallback, useEffect, useRef, useState } from "react";
import { toast } from "sonner";
import { triggerInstantRecordingProcessing } from "@/actions/video/trigger-instant-recording-processing";
import { createVideoAndGetUploadUrl } from "@/actions/video/upload";
import { useEffectMutation, useRpcClient } from "@/lib/EffectRuntime";
import { ThumbnailRequest } from "@/lib/Requests/ThumbnailRequest";
Expand Down Expand Up @@ -1298,6 +1299,17 @@ export const useWebRecorder = ({
setUploadStatus,
);

try {
await triggerInstantRecordingProcessing({
videoId: creationResult.id,
});
} catch (processingError) {
console.error("Failed to start video processing", processingError);
toast.warning(
"Recording uploaded. Processing did not start yet, but the original recording is available.",
);
}

if (thumbnailBlob) {
try {
const screenshotData = await createVideoAndGetUploadUrl({
Expand Down
6 changes: 5 additions & 1 deletion apps/web/workflows/process-video.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ export async function processVideoWorkflow(
);

await saveMetadataAndComplete(videoId, result.metadata);
await cleanupRawUpload(videoId, rawFileKey);

const outputKey = `${userId}/${videoId}/result.mp4`;
if (rawFileKey !== outputKey) {
await cleanupRawUpload(videoId, rawFileKey);
}

return {
success: true,
Expand Down
Loading