Repository navigation
Fix: accept the configured web host in share URL parsing - #2574
Closed
dangzhuotong wants to merge 1 commit into
Closed
dangzhuotong wants to merge 1 commit into
dangzhuotong wants to merge 1 commit into
Conversation
Self-hosted Slack unfurls and /api/oembed dropped /s/<id> links because parseCapShareUrl only allowed cap.so and cap.link. Fixes CapSoftware#2546 Co-authored-by: 卓橦 <dangzhuotong@users.noreply.github.com>
Contributor
|
@dangzhuotong is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2546 — self-hosted Cap never Slack-unfurls (or oEmbeds) share links on the server's own domain because
parseCapShareUrlonly acceptedcap.so/cap.link.This change also accepts the host of
WEB_URLfor the/s/<id>path (lowercase, optional leadingwww.stripped). Hostedcap.soandcap.linkbehavior is unchanged. Invalid/missingWEB_URLdoes not break hosted domains.Self-test
Unit:
apps/web/__tests__/unit/oembed.test.ts,slack-unfurl.test.ts,share-video-metadata.test.ts(34 tests) passed; Biome clean on touched files.Quick check without Slack (expect 200 + oEmbed JSON on self-hosted):
Author
卓橦 (Zhuotong) / @dangzhuotong

Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
parseCapShareUrlnow accepts/s/<id>links on the configuredWEB_URLhostname.Reviews (1) · Last reviewed commit: "fix: accept the configured web host in s..." · Reviewed by Greptile