Repository navigation
fix(recording): exclude pauses that arrive with no media - #2618
Open
yashranaway wants to merge 2 commits into
Open
yashranaway wants to merge 2 commits into
yashranaway wants to merge 2 commits into
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in instant mode the video has its own pipeline, and that pipeline only noticed a pause when a frame showed up while paused. if the screen didn't change during the pause, no frame came in, so the paused time stayed in the video timestamps and the video ended up ahead of the audio by however long you paused.
pause and resume now record the transition at the moment they're called, using the pause tracker the pipeline already shares with its encoders, so a pause counts even when no media arrives during it. the new test pauses a video-only pipeline for 300ms with no frames and checks the next frame's timestamp. it fails on main.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge, with a non-blocking concern about the new test.Findings
Fix with agent prompt
Summary
The PR records pauses even when no media arrives, preventing paused time from entering video timestamps.
Reviews (2) · Last reviewed commit: "fix(recording): read the pause flag unde..." · Reviewed by Greptile