Repository navigation
fix(cli): start Instant recordings behind a start gate - #2654
Merged
Merged
Conversation
The CLI built Instant recordings without a start gate, so its audio was anchored at the first sample while the screen started at its first encoded frame: a microphone that became ready late played early by its start-up delay (about 1 s in the suite's late-mic recording, as in 0.6). Like the desktop app, the CLI now passes a RecordingStartGate and arms it once the recording is built.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cap record --mode instantstarted recordings without a start gate. Its audio was then anchored at the first audio sample while the screen started at its first encoded frame, so a microphone that became ready late played early by its start-up delay. The suite's real-capturerecording/instant/late-miccase measures about 1 s on both 0.6.0 and main.session.start()); this gives the CLI the same start, armed as soon as the recording is built since the CLI has no start cue.

Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
The CLI now builds Instant recordings behind a shared start gate and arms it immediately after the actor is ready.
Reviews (1) · Last reviewed commit: "fix(cli): start Instant recordings behin..." · Reviewed by Greptile