Repository navigation
ci(verify): nightly diff against the cap-v0.6.0 baseline - #2663
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…lled baselines, fail on missing lanes
|
Addressed in 6d549ae:
|
|
@greptileai review |
…s have no baseline record
|
Addressed in 64f98b3: |
|
@greptileai review |
|
Issue 1, in 0d7f07b: the baseline is now the latest completed run in which neither the run nor any job was cancelled or timed out, so every runner reported. Each lane still has to match at least nine tenths of main's cases. Failed baseline runs stay eligible, because 0.6.0 has known failures. |
|
@greptileai review |
… baselines from runs that succeeded or failed
|
Both addressed in c2d41ba:
|
|
@greptileai review |
…artifacts and fail on any download error
|
In 78d5720:
|
|
@greptileai review |
|
In da45510 the workflow also checks this before diffing: every lane main reported (artifact names with tier and shard dropped, as |
|
@greptileai review |
… to the refresh job
|
@greptileai review |
…when main has none
|
Dry run of this workflow's diff job, its
The dry run also showed that the lane step's @greptileai review |
Adds a Baseline diff workflow. Every nightly Engine verify and real-capture run on main is now compared with the cap-v0.6.0 production baseline, case by case. The check fails when main is worse than 0.6.0 anywhere.
How it works
flowchart LR N[nightly run on main: Engine verify or real capture] -->|workflow_run| D[Baseline diff] B[latest run of the same workflow on scratch/prod-baseline] --> D D --> R{WORSE rows?} R -->|yes| F[fail, table in the summary] R -->|no| P[pass] W[weekly cron] --> RB[re-run the baseline workflows]scripts/verify/diff.pygains--fail-on-worse. It exits 1 when a lane has WORSE case rows, or junit rows that went from pass to fail or error. A unit test that main no longer has (renamed or removed with its code) is listed but not counted.scripts/verify/baseline-na.tsvlists cases that cannot exist on 0.6.0 (the captions suite).scratch/prod-baseline, so the baseline artifacts never expire.workflow_dispatchcompares any main run, optionally against a chosen baseline run.First result
Main at
faf032527(Engine verify run 38950431408) against baseline run 38900902858:The three Linux rows are FFmpeg same-clip cross-fades with stale frames (
editing/export/basic/seed-5,editing/export/multi-segment/seed-7,editing/export/same-clip-transition/forward/ffmpeg). #2661 fixes all three.

Confidence Score: 5/5
The latest changes appear safe to merge.Summary
Adds nightly comparisons against the cap-v0.6.0 baseline, with weekly baseline refreshes and report-only recording artifacts.
Reviews (9) · Last reviewed commit: "ci(verify): baseline lane check lists di..." · Reviewed by Greptile