Repository navigation
ci(verify): real-capture recording oracle on GitHub-hosted Windows - #2667
Open
richiemcilroy wants to merge 12 commits into
Open
richiemcilroy wants to merge 12 commits into
richiemcilroy wants to merge 12 commits into
Conversation
…orm priorities in the harness tests
… Windows, Windows camera pacing xfails
…stimulus, log each failure
…nstead of a swap chain
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ots survive fragment renames, required system audio fails without an output device
Member
Author
|
@greptileai review |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the real-capture recording oracle (
crates/verify/tests/recording.rs) on Windows. It records a marker stimulus through Cap's real Studio and Instant pipelines, with Windows Graphics Capture and Media Foundation, and checks every frame and audio marker against the host-clock truth, as it already does on macOS.Where it runs
Verify recordinggains areal-capture (windows-2022)job on GitHub-hosted Windows, and the requiredVerify recordinggate now requires it too.CopyFromScreen: "The handle is invalid", probe runs 38997642473 and 38997747111). Hosted runners run jobs in the interactive console session, where Windows Graphics Capture works.recording/instant/system-onlyis allowed to report unsupported. The microphone and camera are the harness's synthetic feeds, as on macOS.ci-verifyprofile throughengine-verify-setup: about 4 minutes with a warm cache.Harness changes
cap_verify::sched)THREAD_PRIORITY_TIME_CRITICAL, 1 ms timer resolution, high-resolution waitable timer waitsUpdateLayeredWindowcp -cR)crates/recording/src/feeds/microphone.rs, test-utils only). It now registers its stream health, which a recording subscription on Windows and Linux attaches to and a real input registers when it opens.First results, fast tier (run 39005636945)
recording/studio-screen/fragmentedrecording/studio-screen/gatedrecording/instant/screen-mic-systemrecording/instant/gatedrecording/studio-recovery/crashrecording/instant/late-micrecording/studio-camera/startup-dropsrecording/instant/system-onlyWhat it found


Confidence Score: 5/5
The PR appears safe to merge, with no new blocking issues found.Summary
Adds real recording checks on GitHub-hosted Windows and requires them in the recording gate.
No new actionable issues were found in the changes since the previous review.
Reviews (2) · Last reviewed commit: "fix(verify): Windows stimulus audio uses..." · Reviewed by Greptile