Skip to content

fix(cli): emit JSON for recording validation errors - #2680

Merged
richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/cli-record-validation-json
Oct 18, 2026
Merged

richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/cli-record-validation-json

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

with --json, a bad record flag like a zero or NaN duration, zero fps, or no target exited with code 1 and nothing on stdout. the check ran before either of the json error handlers, so scripts and agents parsing the output just got an empty response.

now validation and recording errors share one handler, which also removes the two copies that were wrapping foreground and detached runs. plain text output and exit codes are the same as before. the test runs every bad flag through record, record start and detached start.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Recording validation errors now produce JSON error events through the same handler as foreground and detached recording errors.

  • Recording starts now report every failure as a JSON error event.

Reviews (1) · Last reviewed commit: "fix(cli): emit JSON for recording valida..." · Reviewed by Greptile

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@vercel

vercel Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@richiemcilroy
richiemcilroy merged commit b37951c into CapSoftware:main Oct 18, 2026
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants