Repository navigation
fix(cli): emit JSON for recording validation errors - #2680
Merged
richiemcilroy merged 2 commits intoOct 18, 2026
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with --json, a bad record flag like a zero or NaN duration, zero fps, or no target exited with code 1 and nothing on stdout. the check ran before either of the json error handlers, so scripts and agents parsing the output just got an empty response.
now validation and recording errors share one handler, which also removes the two copies that were wrapping foreground and detached runs. plain text output and exit codes are the same as before. the test runs every bad flag through record, record start and detached start.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge.Summary
Recording validation errors now produce JSON error events through the same handler as foreground and detached recording errors.
Reviews (1) · Last reviewed commit: "fix(cli): emit JSON for recording valida..." · Reviewed by Greptile