Skip to content

test(verify): soak holds end before the stimulus does at any length - #2688

Merged
richiemcilroy merged 1 commit into
mainfrom
fix/soak-short-holds
Oct 17, 2026
Merged

richiemcilroy merged 1 commit into
mainfrom
fix/soak-short-holds

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #2666, from capy's review: the soak cases' scripted holds had fixed lengths, so a short CAP_VERIFY_SOAK_SECS put a hold over the end of the stimulus. With 30 s, the Studio soak's 10 s hold started at 20 s and ran to the end. The stimulus never showed its last picture, and the case hung until its timeout.

Holds now scale with the length and end by five sixths of it: Studio 3 s at 1/3 and 10 s at 2/3, Instant 5 s at 1/2, each capped at a tenth or a sixth of the length. At 1800 s the holds are unchanged.

CAP_VERIFY_SOAK_SECS=30 on a MacBook Pro: both soak cases pass (Studio 35.9 s, Instant 35.0 s).

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

The PR scales scripted holds for shorter soak runs while keeping the original hold lengths at 1800 seconds.

  • Soak recordings scale their holds to finish before the stimulus ends.

Reviews (1) · Last reviewed commit: "test(verify): soak holds end before the ..." · Reviewed by Greptile

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

Open in Capy

@richiemcilroy
richiemcilroy merged commit b6ce320 into main Oct 17, 2026
46 checks passed

This branch was successfully deployed

2 active deployments
Preview – cap-web — b069b9a1 Deployed Oct 17, 2026 by vercel[bot]
Preview – cap-status — b069b9a1 Deployed Oct 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant