Repository navigation
test(verify): soak holds end before the stimulus does at any length - #2688
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2666, from capy's review: the soak cases' scripted holds had fixed lengths, so a short
CAP_VERIFY_SOAK_SECSput a hold over the end of the stimulus. With 30 s, the Studio soak's 10 s hold started at 20 s and ran to the end. The stimulus never showed its last picture, and the case hung until its timeout.Holds now scale with the length and end by five sixths of it: Studio 3 s at 1/3 and 10 s at 2/3, Instant 5 s at 1/2, each capped at a tenth or a sixth of the length. At 1800 s the holds are unchanged.
CAP_VERIFY_SOAK_SECS=30on a MacBook Pro: both soak cases pass (Studio 35.9 s, Instant 35.0 s).

Confidence Score: 5/5
The PR appears safe to merge.Summary
The PR scales scripted holds for shorter soak runs while keeping the original hold lengths at 1800 seconds.
Reviews (1) · Last reviewed commit: "test(verify): soak holds end before the ..." · Reviewed by Greptile